Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLT-689 custom headers #58

Merged
merged 13 commits into from
Dec 20, 2023
Merged

SPLT-689 custom headers #58

merged 13 commits into from
Dec 20, 2023

Conversation

pekkalehtomaki
Copy link
Contributor

@pekkalehtomaki pekkalehtomaki commented Dec 20, 2023 •
edited
Loading

Relevant Tickets:
Part of https://mapbox.atlassian.net/browse/SPLT-689

Summary of Changes

  • Adds option to include given headers in requests. This is useful e.g. when replaying logs on an ELB which has requiredHeaders implemented.

Testing Strategy

Tested with wiretap

@pekkalehtomaki pekkalehtomaki marked this pull request as ready for review December 20, 2023 11:07
krydima
krydima approved these changes Dec 20, 2023
View reviewed changes
Copy link

@krydima krydima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pekkalehtomaki pekkalehtomaki merged commit a10337f into main Dec 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krydima krydima krydima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pekkalehtomaki @krydima