Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails with old Jinja version #459

Open
ben-heil opened this issue Feb 22, 2022 · 1 comment
Open

Build fails with old Jinja version #459

ben-heil opened this issue Feb 22, 2022 · 1 comment

Comments

@ben-heil
Copy link

Putting this issue here in case other people run into the same error. It's fixable by pulling the new version of rootstock, but that isn't obvious from the build error message

The people who develop Markupsafe pushed a breaking change that causes old versions of Jinja2 to break unless you manually pin an old version of Markupsafe to work around it. The official line seems to be "it's your fault for not updating Jinja", so I imagine there isn't a fix coming.

Again, this isn't an issue with the live version of rootstock, but does break builds for anyone who hasn't updated rootstock since December
image

@agitter
Copy link
Member

agitter commented Feb 23, 2022

Thanks for pointing this out @ben-heil. I'm adding the text of the error message to help anyone who searches for a solution.

ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/usr/share/miniconda3/envs/manubot/lib/python3.7/site-packages/markupsafe/__init__.py)

If this is a widespread problem, we can pin this issue to make it easier to find.

dcsoto pushed a commit to computer-aided-biotech/better-cb that referenced this issue Feb 25, 2022
New version of Markup safe breaks with old Jinja version. To work around it, an older version of Markupsafe needs to be manually added (manubot/rootstock#459). I added version 2.0.1 to the environment YAML (pallets/markupsafe#284).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants