Add Top and Bottom row combos for QWERTY. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provided combos are simply the corner keys on QWERTY.
The added combos are simply the corner pinky keys for QWERTY.
|
Great, thanks! |
mattdibi
added a commit
to mattdibi/miryoku_zmk
that referenced
this pull request
Jan 4, 2023
|
The code changes have been added in b6c2e1d. I'll add the docs later after editing. Thanks! |
Purple zen
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds the top and bottom row combos into the respective MIRYOKU_KLUDGE files for the QWERTY layout.
This ensures the top and bottom row combos work as expected if someone decides to enable them, and will be useful until they are automatically generated.
I have additionally added some basic documentation for the features.