Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix github actions #238

Merged
merged 7 commits into from
Jan 17, 2022
Merged

Fix github actions #238

merged 7 commits into from
Jan 17, 2022

Conversation

manikmagar
Copy link
Owner

Reverts #234. Sonar fails for PRs from forks. Will keep this for development branches in origin.

@manikmagar manikmagar changed the title Revert "remove sonar analysis" Fix github actions Jan 17, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@manikmagar manikmagar merged commit 1249995 into master Jan 17, 2022
@manikmagar manikmagar deleted the revert-234-chore/sonar-action branch January 17, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@manikmagar