Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set count of ignored word to N #108

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Conversation

mammothb
Copy link
Owner

@mammothb mammothb commented Dec 8, 2021

Previously the count of these ignored words were set to 0, causing lookup_compound to always return suggestion count as 0 after it was changed to use Naive Bayes probability.

This sets the count of ignored words to N so they will not affect the final suggestion count/probability.

@mammothb mammothb added the bug Something isn't working label Dec 8, 2021
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #108 (84121c5) into master (1098ff2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #108   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          820       820           
  Branches       196       196           
=========================================
  Hits           820       820           
Impacted Files Coverage Δ
symspellpy/symspellpy.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1098ff2...84121c5. Read the comment docs.

@mammothb mammothb merged commit 84689da into master Dec 8, 2021
@mammothb mammothb deleted the fix-ignore_words_count branch December 8, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant