Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable auto conversion of sub-classes of list, dict, and tuple #51

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

youralmight
Copy link

Update init.py so that EasyDict does not convert subclasses of dict, tuple, and list like datasets.dataset_dict.DatasetDict

…uple, and list like datasets.dataset_dict.DatasetDict
Copy link
Collaborator

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test to demonstrate your changes?
Thank you

Add `test.py` to validate the auto-conversion of `list`, `tuple`, and `dict`, and to validate the non-auto-conversion of their subclasses.
… `dict`, and to validate the non-auto-conversion of their subclasses.
@youralmight youralmight reopened this Jul 17, 2024
@youralmight
Copy link
Author

I added unittest to validate it.

@youralmight
Copy link
Author

@leplatrem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants