Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix the sync endpoint #5753

Merged
merged 1 commit into from
Oct 4, 2024
Merged

chore: Fix the sync endpoint #5753

merged 1 commit into from
Oct 4, 2024

Conversation

SatishGandham
Copy link
Collaborator

@SatishGandham SatishGandham commented Oct 4, 2024

Summary by CodeRabbit

  • New Features

    • Updated the paginated issues endpoint to include project ID in the URL structure for better context.
    • Enhanced issue retrieval logic to streamline access based on project ID.
  • Bug Fixes

    • Added validation for guest users to restrict access to issues based on project permissions.
  • Refactor

    • Simplified the logic for retrieving and filtering issues, improving overall clarity and functionality.

Copy link
Contributor

coderabbitai bot commented Oct 4, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request primarily involve updating the URL routing for issue-related endpoints in a Django application. The path for the paginated issues endpoint has been modified to include a project ID, aligning it with other issue-related endpoints. Additionally, the IssuePaginatedViewSet class in the views has been updated to handle the project ID more effectively, including changes to the get_queryset and list methods. The IssueService in TypeScript has also been adjusted to simplify the construction of the API endpoint URL.

Changes

File Change Summary
apiserver/plane/app/urls/issue.py Updated URL path for paginated issues to include project_id.
apiserver/plane/app/views/issue/base.py Modified IssuePaginatedViewSet to handle project_id, update get_queryset, and list methods.
web/core/services/issue/issue.service.ts Simplified URL construction in getIssuesForSync to include projectId directly in the endpoint.

Possibly related PRs

Suggested labels

⚙️backend

Suggested reviewers

  • NarayanBavisetti

Poem

🐰 In the garden where issues grow,
A path was changed, now it flows,
With project IDs, clear and bright,
Our queries dance in the soft moonlight.
Hopping through code, we celebrate,
A better way to collaborate! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pushya22 pushya22 merged commit 01257a6 into preview Oct 4, 2024
11 of 14 checks passed
@pushya22 pushya22 deleted the fix-sync-endpoint branch October 4, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants