[WEB-2443] fix: project member validation

[anmolsinghbhatia]

Changes:

This PR resolves the issue with role validation in project member settings.

Reference:

[WEB-2443]

Summary by CodeRabbit

• New Features

  • Enhanced role management flexibility by allowing GUEST roles to be treated similarly to ADMIN roles regarding editability.
  • Updated logic for determining editable roles based on user permissions, potentially increasing available roles for editing.

• Bug Fixes

  • Improved accuracy of role filtering based on current member's workspace role.

[coderabbitai]

Walkthrough

The changes in this pull request modify the logic for determining user roles and their editability within the AccountTypeColumn component. The criteria for non-editable roles have been broadened to include both ADMIN and GUEST roles. Additionally, the function checkCurrentOptionWorkspaceRole has been updated to filter roles based on these new criteria, potentially allowing for more roles to be available for editing depending on the user's role.

Changes

Files	Change Summary
web/core/components/project/settings/member-columns.tsx	Updated logic for user role editability to include GUEST roles alongside ADMIN roles. Altered filtering criteria in checkCurrentOptionWorkspaceRole to accommodate these changes.

Possibly related PRs

• [WEB-2391] fix: join project permission mutation #5580: Modifies user project role management, related to changes in user role editability.
• [WEB-2443] fix: project favorite permission validation #5587: Enhances permission checks for the ProjectCard component, aligning with the focus on modifying role editability.
• [WEB-2443] fix: project intake edit permission #5588: Addresses project intake permissions for guest users, relevant to the broadening of editability conditions for user roles.

Suggested labels

🐛bug, 🌐frontend

🐇 In the meadow, roles now play,
GUESTs can edit, come what may!
ADMINs and GUESTs, side by side,
Flexibility is now our guide.
Hop along, with joy we cheer,
For every role, a chance is near! 🌼✨

Tip

OpenAI O1 model for chat

• We have deployed OpenAI's latest O1 model for chat.
• OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
• Please share any feedback with us in the discussions post.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

web/core/components/project/settings/member-columns.tsx (1)

107-107: Rename the variable to isGuestOrOwner for consistency.

The code segment correctly checks if the current member's workspace role is either ADMIN or GUEST. However, the variable name isGuestOROwner is inconsistent with the naming convention used in the rest of the code. Please rename it to isGuestOrOwner for consistency.

Apply this diff to rename the variable:

-const isGuestOROwner = [EUserPermissions.ADMIN, EUserPermissions.GUEST].includes(currentMemberWorkspaceRole);
+const isGuestOrOwner = [EUserPermissions.ADMIN, EUserPermissions.GUEST].includes(currentMemberWorkspaceRole);

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b44dd28 and caf368f.

Files selected for processing (1)

• web/core/components/project/settings/member-columns.tsx (1 hunks)

Additional comments not posted (3)

web/core/components/project/settings/member-columns.tsx (3)

100-100: LGTM!

The code segment correctly checks if the user's role is either ADMIN or GUEST and assigns the result to the isAdminOrGuest variable. The variable name accurately describes the condition being checked.

---

101-101: LGTM!

The code segment correctly checks if the user is the current user or if their role is ADMIN or GUEST and assigns the result to the isRoleNonEditable variable. The variable name accurately describes the condition being checked.

---

110-110: LGTM!

The code segment correctly filters the ROLE object entries based on the current member's workspace role. If the current member is a guest or owner, only their current role is included in the filtered entries. This ensures that only the appropriate roles are available for selection based on the current member's workspace role.