-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-2316] chore: use-platform-os hook optimization to not cause re renders #5453
Conversation
WalkthroughThe changes to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/ui/src/hooks/use-platform-os.ts (1 hunks)
- web/core/hooks/use-platform-os.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/ui/src/hooks/use-platform-os.ts
Additional comments not posted (2)
web/core/hooks/use-platform-os.tsx (2)
4-6
: LGTM!The code correctly retrieves the user agent and determines the mobile status. The initialization of the
platform
variable is appropriate.The code changes are approved.
8-18
: LGTM!The code correctly identifies the platform based on the user agent string. The logic is straightforward and efficient.
The code changes are approved.
}, []); | ||
platform = "Unknown"; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets return the platform for mobile as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we take that as a separate task as?, the change will require more testing on the devices
Modify usePlatformOS hook to not cause re renders in components by directly assigning values instead of using useEffect and useState to get values.
Summary by CodeRabbit
New Features
usePlatformOS
hook for improved efficiency in detecting mobile platforms and operating systems.Bug Fixes
Documentation
usePlatformOS
hook.