Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-2114]: Chore: project cycle optimization #5430

Merged
merged 12 commits into from
Aug 27, 2024
Merged

[WEB-2114]: Chore: project cycle optimization #5430

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3222c4a
chore: project cycle optimization
NarayanBavisetti Aug 26, 2024
cec4a41
fix: typo
NarayanBavisetti Aug 26, 2024
08ec56d
chore: changed the label typo
NarayanBavisetti Aug 26, 2024
712eaf0
feat: intergrated optimized api
gakshita Aug 26, 2024
8cd3c7a
Merge branch 'chore/project-cycle-optimization' of https://github.com…
gakshita Aug 26, 2024
251b21e
chore: added every key as plural
NarayanBavisetti Aug 26, 2024
91b57b3
Merge branch 'chore/project-cycle-optimization' of github.com:makepla…
NarayanBavisetti Aug 26, 2024
8c7c4ca
fix: productivity dropdown
gakshita Aug 26, 2024
7249c72
Merge branch 'chore/project-cycle-optimization' of https://github.com…
gakshita Aug 26, 2024
5777ee8
fix: removed logging
gakshita Aug 26, 2024
94c1262
fix: handled loading
gakshita Aug 27, 2024
20a0e3f
fix: loaders
gakshita Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions apiserver/plane/app/urls/cycle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
CycleIssueViewSet,
CycleDateCheckEndpoint,
CycleFavoriteViewSet,
CycleProgressEndpoint,
CycleAnalyticsEndpoint,
TransferCycleIssueEndpoint,
CycleUserPropertiesEndpoint,
CycleArchiveUnarchiveEndpoint,
Expand Down Expand Up @@ -106,4 +108,14 @@
CycleArchiveUnarchiveEndpoint.as_view(),
name="cycle-archive-unarchive",
),
path(
"workspaces/<str:slug>/projects/<uuid:project_id>/cycles/<uuid:cycle_id>/progress/",
CycleProgressEndpoint.as_view(),
name="project-cycle",
),
path(
"workspaces/<str:slug>/projects/<uuid:project_id>/cycles/<uuid:cycle_id>/analytics/",
CycleAnalyticsEndpoint.as_view(),
name="project-cycle",
),
]
2 changes: 2 additions & 0 deletions apiserver/plane/app/views/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@
CycleUserPropertiesEndpoint,
CycleViewSet,
TransferCycleIssueEndpoint,
CycleAnalyticsEndpoint,
CycleProgressEndpoint,
Comment on lines +101 to +102
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused imports.

The CycleAnalyticsEndpoint and CycleProgressEndpoint are imported but not used in the file. Consider removing them or adding them to __all__.

Apply this diff to remove the unused imports:

-    CycleAnalyticsEndpoint,
-    CycleProgressEndpoint,

Alternatively, if these endpoints are intended to be used elsewhere, add them to __all__:

+__all__ = [
+    ...
+    "CycleAnalyticsEndpoint",
+    "CycleProgressEndpoint",
+]
Tools
Ruff

101-101: .cycle.base.CycleAnalyticsEndpoint imported but unused; consider removing, adding to __all__, or using a redundant alias

(F401)

102-102: .cycle.base.CycleProgressEndpoint imported but unused; consider removing, adding to __all__, or using a redundant alias

(F401)

)
from .cycle.issue import (
CycleIssueViewSet,
Expand Down
Loading
Loading