-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-2001]feat: Cache issues on the client #5327
Merged
Merged
Changes from 131 commits
Commits
Show all changes
133 commits
Select commit
Hold shift + click to select a range
957e981
use common getIssues from issue service instead of multiple different…
rahulramesha ede4d43
Merge remote-tracking branch 'origin/chore-common-getIssues-API' into…
SatishGandham cc0d229
Use SQLite to store issues locally and load issues from it.
SatishGandham 915757c
Fix incorrect total count and filtering on assignees.
SatishGandham 0656de2
enable parallel API calls
rahulramesha f8d78ac
use common getIssues from issue service instead of multiple different…
rahulramesha 5edfb5c
Use SQLite to store issues locally and load issues from it.
SatishGandham 52b495d
Fix incorrect total count and filtering on assignees.
SatishGandham 322e9a9
enable parallel API calls
rahulramesha 705f23f
chore: deleted issue list
NarayanBavisetti 8ecdd12
- Handle local mutations
SatishGandham 5e120f7
Wait for sync to complete in get issues
SatishGandham 620bd0c
Fix build errors
SatishGandham 0e4f54f
Merge branch 'feat_no_loader_SQLite' of https://github.com/makeplane/…
SatishGandham 4e85f00
Fix build issue
SatishGandham 48a8043
- Sync updates to local-db
SatishGandham d315728
Add issues in batches
SatishGandham 537ed92
Disable skeleton loaders for first 10 issues
SatishGandham 21b3924
Load issues in bulk
SatishGandham d2f530f
working version of sql lite with grouped issues
rahulramesha 6c7a13d
Merge branch 'feat-noloader-sqlite' of github.com:makeplane/plane int…
rahulramesha 2fdf4f4
Use window queries for group by
SatishGandham 35d2397
- Fix sort by date fields
SatishGandham 3617ae7
- Fix grouping by created by
SatishGandham 0cbb164
fix pagination
rahulramesha d67d5c0
Fix sorting on issue priority
SatishGandham 174e079
- Add secondary sort order
SatishGandham 7816667
chore: added timestamp filter for deleted issues
NarayanBavisetti 53fe270
Merge branch 'feat-noloader-sqlite' of github.com:makeplane/plane int…
NarayanBavisetti 107ba8f
- Extract local DB into its own class
SatishGandham e75f7b1
Implement subgroup by
SatishGandham 3ac9132
sub group by changes
rahulramesha 673b2fb
Refactor query constructor
SatishGandham 3c8b27d
Insert or update issues instead of directly adding them.
SatishGandham 1a1eb0d
Segregated queries. Not working though!!
SatishGandham 59b19fa
- Get filtered issues and then group them.
SatishGandham ac40489
Fix build issues
SatishGandham 4215094
Remove debuggers
SatishGandham 5dc8a82
remove loaders while changing sorting or applying filters
rahulramesha 64ba84c
Merge branch 'feat-noloader-sqlite' of github.com:makeplane/plane int…
rahulramesha 83e7b4f
fix loader while clearing all filters
rahulramesha d3b9e10
Fix issue with project being synced twice
SatishGandham 40704c1
Improve project sync
SatishGandham 7f3ec53
Optimize the queries
SatishGandham 317ae96
Make create dummy data more realistic
SatishGandham c7899c6
Merge branch 'preview' into feat-noloader-sqlite
SatishGandham fae4314
dev: added total pages in the global paginator
gurusainath 921c142
chore: updated total_paged count
gurusainath 06b1ecf
chore: added state_group in the issues pagination
gurusainath 8bc1924
chore: removed deleted_at from the issue pagination payload
gurusainath 5600257
chore: replaced state_group with state__group
gurusainath 83d2384
Integrate new getIssues API, and fix sync issues bug.
SatishGandham 9dc26b6
Fix issue with SWR running twice in workspace wrapper
SatishGandham 0305e7d
Fix DB initialization called when opening project for the first time.
SatishGandham ef7ca4e
Add all the tables required for sorting
SatishGandham 79a2b94
Exclude description from getIssues
SatishGandham ec0a2a5
Add getIssue function.
SatishGandham 87a9c38
Add only selected fields to get query.
SatishGandham 43fe5af
Fix the count query
SatishGandham 24e6b3c
Minor query optimization when no joins are required.
SatishGandham cb682ef
fetch issue description from local db
rahulramesha 76c2d92
Merge branch 'feat-noloader-sqlite' of github.com:makeplane/plane int…
rahulramesha 6bf6a06
clear local db on signout
rahulramesha 14101e8
Correct dummy data creation
SatishGandham c6194d8
Merge branch 'feat-noloader-sqlite' of https://github.com/makeplane/p…
SatishGandham 02700ba
Fix sort by assignee
SatishGandham 7d5ab1b
sync to local changes
rahulramesha 5394416
Merge branch 'feat-noloader-sqlite' of github.com:makeplane/plane int…
rahulramesha d430b68
chore: added archived issues in the deleted endpoint
NarayanBavisetti ae5dfe0
Sync deletes to local db.
SatishGandham d9a0ae2
- Add missing indexes for tables used in sorting in spreadsheet layout.
SatishGandham d43c34c
Make fallback optional in getOption
SatishGandham 45d8538
Kanban column virtualization
rahulramesha 25afc04
Merge branch 'feat-noloader-sqlite' of github.com:makeplane/plane int…
rahulramesha c63ea98
persist project sync readiness to sqlite and use that as the source o…
rahulramesha d93a1d4
fix build errors
rahulramesha be83dd1
Merge branch 'preview' into feat-noloader-sqlite
SatishGandham 1263650
Fix calendar view
SatishGandham 7ee6fea
fetch slimed down version of modules in project wrapper
rahulramesha 6a493bf
Merge branch 'preview' of github.com:makeplane/plane into feat-noload…
rahulramesha 42fb1d7
fetch toned down modules and then fetch complete modules
rahulramesha 89ae846
Fix multi value order by in spread sheet layout
SatishGandham 5bc359d
Fix sort by
SatishGandham 89f43ad
Fix the query when ordering by multi field names
SatishGandham 2c4c241
Remove unused import
SatishGandham 7e66115
Fix sort by multi value fields
SatishGandham e63bcc4
Format queries and fix order by
SatishGandham 7238b18
fix order by for multi issue
rahulramesha a1522b1
fix loaders for spreadsheet
rahulramesha 0f45b56
Fallback to manual order whn moving away from spreadsheet layout
SatishGandham 33c0cfe
Merge branch 'preview' into feat-noloader-sqlite
SatishGandham f6e58ce
fix minor bug
rahulramesha a1da35f
Move fix for order_by when switching from spreadsheet layout to trans…
SatishGandham 4c901a9
Merge branch 'feat-noloader-sqlite' of https://github.com/makeplane/p…
SatishGandham 3527a7b
fix default rendering of kanban groups
rahulramesha 0de0db7
Merge branch 'feat-noloader-sqlite' of https://github.com/makeplane/p…
SatishGandham ece0b21
Fix none priority being saved as null
SatishGandham f191df9
Merge branch 'preview' of github.com:makeplane/plane into feat-noload…
rahulramesha 08f57a8
Remove debugger statement
SatishGandham 2fc8ab5
Fix issue load
SatishGandham b791b31
chore: updated isue paginated query from to
gurusainath 6b2d5ad
Fix sub issues and start and target date filters
SatishGandham ffd18cd
Fix active and backlog filter
SatishGandham e39d17c
Add default order by
SatishGandham bce8f2d
Update the Query param to match with backend.
SatishGandham 799aeab
local sqlite db versioning
rahulramesha 13a7a5f
When window is hidden, do not perform any db versioning
rahulramesha f983337
fix error handling and fall back to server when database errors out
rahulramesha ea83e3c
Add ability to disable local db cache
rahulramesha a903aec
remove db version check from getIssues function
rahulramesha 052d5ec
change db version to number and remove workspaceInitPromise in storag…
rahulramesha 1e74d88
- Sync the entire workspace in the background
SatishGandham 8f0dee9
Make changes to get issues for sync to match backend.
SatishGandham e53bc00
chore: handled workspace and project in v2 paginted issues
gurusainath 9a204dd
Merge branch 'feat-noloader-sqlite' of gurusainath:makeplane/plane in…
gurusainath cb3e8be
disable issue description and title until fetched from server
rahulramesha 6ccdaa4
sync issues post bulk operations
rahulramesha b117e1c
Merge branch 'preview' of github.com:makeplane/plane into feat-noload…
rahulramesha 5b957f4
fix server error
rahulramesha c2fd781
fix front end build
rahulramesha 8390f6d
Remove full workspace sync
SatishGandham 8787072
Merge branch 'preview' of https://github.com/makeplane/plane into fea…
SatishGandham 282bcee
Merge branch 'preview' of https://github.com/makeplane/plane into fea…
SatishGandham d4e71f5
- Remove the toast message on sync.
SatishGandham 9aa8a7c
Add Hardcoded constant to disable the local db caching
rahulramesha f2f2fca
fix lint errors
rahulramesha 00685a8
Fix order by in grouping
SatishGandham 9d3055a
Merge branch 'feat-noloader-sqlite' of https://github.com/makeplane/p…
SatishGandham 81ed15a
Merge branch 'preview' of github.com:makeplane/plane into feat-noload…
rahulramesha b1d8edb
update yarn lock
rahulramesha 7fd7e67
fix build
rahulramesha 5a16b2e
fix plane-web imports
rahulramesha f220592
address review comments
rahulramesha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security concern: 'project_id' obtained from GET parameters without validation
In the
IssuePaginatedViewSet
,project_id
is fetched from GET parameters in both theget_queryset
(lines 745-753) andlist
methods (lines 796-800). Similarly, it's used in filtering thebase_queryset
(lines 838-840). Relying onproject_id
from GET parameters without proper validation and permission checks may allow unauthorized access to issues from other projects.Recommendation:
Ensure that
project_id
is obtained from URL parameters or validate it thoroughly when sourced from GET parameters. Implement necessary permission checks to prevent potential security risks associated with unauthorized data access.Also applies to: 796-800, 838-840