-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-1886] fix: mutating the total issues count in the archived issues header when we restore or remove issues from archives #5192
Conversation
…restore the issues
WalkthroughThe update to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/archives/header.tsx (1 hunks)
Additional comments not posted (2)
web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/archives/header.tsx (2)
29-29
: LGTM! Simplified issue count calculation.The use of
getGroupIssueCount
directly improves code readability and maintainability.
35-35
: LGTM! Centralized issue counting logic.The use of
getGroupIssueCount
centralizes the logic for counting issues, improving maintainability. Ensure that the parameters passed togetGroupIssueCount
are correct and cover all intended cases.
Problem Statement:
In the Archived issues, when we restore the issue the total issues count is not mutating in the archived issue header
Solution:
When we restore the issues, we update the total issues count in the archived issues header.
Changes:
Plane Issue:
[WEB-1886]
Summary by CodeRabbit