Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-2021] fix: mutating the inbox count on the sidebar and inbox tab when we click mark all as read #5191

Merged

Conversation

gurusainath
Copy link
Collaborator

@gurusainath gurusainath commented Jul 22, 2024

Problem Statement:

In the inbox, when we click the option mark all as read the notification count is not mutating in the workspace app sidebar badge and inbox tab badge

Solution:

When we click mark all as read in the inbox we are mutating the store unread notification count observer

Changes:

  1. workspace notification store

Plane Issue:

[WEB-2021]

Summary by CodeRabbit

  • New Features
    • Enhanced notification management to accurately reflect unread counts when marking notifications as read, improving user experience.

Copy link
Contributor

coderabbitai bot commented Jul 22, 2024

Walkthrough

The changes enhance the WorkspaceNotificationStore class by refining how notifications are marked as read. A new code block updates the unread notifications count based on the active notification tab, ensuring accurate representation of unread messages. This improvement optimizes user experience by providing clearer feedback on notification states.

Changes

File Change Summary
web/core/store/notifications/...store.ts Enhanced the WorkspaceNotificationStore to update unread counts when marking notifications as read.

Poem

In the meadow where notifications bloom,
A bunny hops, dispelling the gloom.
With counts that now sing and cheer,
Each message read brings joy, my dear!
So let’s celebrate with a joyful dance,
For clear updates give our hearts a chance! 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9c1c0ed and e082519.

Files selected for processing (1)
  • web/core/store/notifications/workspace-notifications.store.ts (1 hunks)
Additional comments not posted (1)
web/core/store/notifications/workspace-notifications.store.ts (1)

376-382: LGTM! But verify the correct usage of the update function and currentNotificationTab.

The code changes are approved. The update function is used to set the unread notifications count to zero based on the current notification tab.

However, ensure that the update function is used correctly and that the currentNotificationTab is set appropriately elsewhere in the code.

@SatishGandham SatishGandham merged commit 3545d94 into preview Jul 22, 2024
13 of 14 checks passed
@SatishGandham SatishGandham deleted the fix/notification_workspace_count_mark_all_read branch July 22, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants