Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-2004] fix: empty issue title indicator #5173

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[WEB-2004] fix: empty issue title indicator #5173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web/core/components/issues/title-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export const IssueTitleInput: FC<IssueTitleInputProps> = observer((props) => {
className={cn(
"block w-full resize-none overflow-hidden rounded border-none bg-transparent px-3 py-0 text-2xl font-medium outline-none ring-0",
{
"ring-1 ring-red-400 mx-3": title.length && title.length === 0,
"ring-1 ring-red-400 mx-2.5": title?.length === 0,
},
className
)}
Expand All @@ -134,7 +134,7 @@ export const IssueTitleInput: FC<IssueTitleInputProps> = observer((props) => {
/255
</div>
</div>
{title.length && title.length === 0 && <span className="text-sm text-red-500">Title is required</span>}
{title?.length === 0 && <span className="text-sm text-red-500">Title is required</span>}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can title be undefined here?

</div>
);
});
Loading