Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-1415] fix: issue attachment count mutation #4567

Merged
merged 2 commits into from
May 24, 2024

Conversation

aaryan610
Copy link
Collaborator

Problem:

After uploading/removing an attachment, the attachment count doesn't mutate.

Solution:

Added the updateIssue logic to update the attachment count post addition/removal.

Plane issue: WEB-1415

@@ -131,13 +139,17 @@ export class IssueAttachmentStore implements IIssueAttachmentStore {
issueId,
attachmentId
);
const issueAttachmentsCount = this.getAttachmentsByIssueId(issueId)?.length ?? 1;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the default value is 1?

@SatishGandham SatishGandham merged commit 9f573d4 into preview May 24, 2024
13 of 14 checks passed
@SatishGandham SatishGandham deleted the fix/attachment-count branch May 24, 2024 09:03
@srinivaspendem srinivaspendem modified the milestones: v0.20-dev, v0.21-dev May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants