Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-675] fix: analytics dialog close on outside click #3987

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

1akhanBaheti
Copy link
Collaborator

@1akhanBaheti 1akhanBaheti commented Mar 19, 2024

Problem:

When the analytics section is open, clicking outside of the dialog does not closing the dialog.

image

Solution:

Wrapped the Dialog with div & its class.

analytics-dialog.mp4

This PR is attached to issue WEB-675

@1akhanBaheti 1akhanBaheti added this to the v0.17.0-dev milestone Mar 19, 2024
@1akhanBaheti 1akhanBaheti self-assigned this Mar 19, 2024
@1akhanBaheti 1akhanBaheti changed the title fix: analytics dialog close on outside click [WEB-675] fix: analytics dialog close on outside click Mar 19, 2024
@1akhanBaheti 1akhanBaheti marked this pull request as ready for review March 19, 2024 11:36
@sriramveeraghanta sriramveeraghanta merged commit 6a245e1 into develop Mar 20, 2024
12 of 14 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/analytics-dialog branch March 20, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants