Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inline code blocks, code blocks and links have saner behaviour #3318

Merged
merged 5 commits into from
Jan 11, 2024
Merged

fix: inline code blocks, code blocks and links have saner behaviour #3318

merged 5 commits into from
Jan 11, 2024

Conversation

Palanikannan1437
Copy link
Collaborator

@Palanikannan1437 Palanikannan1437 commented Jan 5, 2024 •
edited
Loading

Description

  • Inline code blocks are now exitable, don't have backticks, have better padding vertically and better regex matching
    • immediately exitable using space
    • Exitable to next line using right arrow key
    • Can be surrounded using other chars like (, {, etc with the improved regex pattern matching
    • Inorder to actually show show backticks in the document like `s`, first type in `` and then put your cursor inside the backticks and start typing text, intended behaviour in Tiptap
    • Removed backticks from displaying in the inline code blocks
inline-code.mp4
  • Code blocks on the top and bottom of the document are now exit-able via Up and Down Arrow keys
code.block.exitable.mp4
  • Links are now exit-able while being auto-linkable typing and pasting links via a custom re-write of the tiptap-link-extension.
links.new.behaviour.mp4
  • Added better error handling while cancelling uploads

@Palanikannan1437
fix: removed backticks in inline code blocks
927ab50
@Palanikannan1437
added better error handling while cancelling uploads
d8f1404
@Palanikannan1437
fix: inline code blocks, code blocks and links have saner behaviour
bb4bee0 
- Inline code blocks are now exitable, don't have backticks, have better padding vertically and better regex matching
- Code blocks on the top and bottom of the document are now exitable via Up and Down Arrow keys
- Links are now exitable while being autolinkable via a custom re-write of the tiptap-link-extension
@Palanikannan1437 Palanikannan1437 self-assigned this Jan 5, 2024
@Palanikannan1437 Palanikannan1437 marked this pull request as draft January 5, 2024 06:48
@Palanikannan1437 Palanikannan1437 changed the title fix: removed backticks in inline code blocks fix: inline code blocks, code blocks and links have saner behaviour Jan 5, 2024
@Palanikannan1437 Palanikannan1437 marked this pull request as ready for review January 11, 2024 08:29
@Palanikannan1437 Palanikannan1437 added 🐛bug Something isn't working ✍️editor labels Jan 11, 2024
@sriramveeraghanta sriramveeraghanta merged commit 3d489e1 into develop Jan 11, 2024
6 of 8 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/base-extensions branch January 11, 2024 12:59
sriramveeraghanta pushed a commit that referenced this pull request Jan 22, 2024
@Palanikannan1437 @sriramveeraghanta
fix: inline code blocks, code blocks and links have saner behaviour (#…
4dfe1ef 
…3318)

* fix: removed backticks in inline code blocks

* added better error handling while cancelling uploads

* fix: inline code blocks, code blocks and links have saner behaviour

- Inline code blocks are now exitable, don't have backticks, have better padding vertically and better regex matching
- Code blocks on the top and bottom of the document are now exitable via Up and Down Arrow keys
- Links are now exitable while being autolinkable via a custom re-write of the tiptap-link-extension

* fix: more robust link checking
sriramveeraghanta pushed a commit that referenced this pull request Jan 22, 2024
@Palanikannan1437 @sriramveeraghanta
fix: inline code blocks, code blocks and links have saner behaviour (#…
27762ea 
…3318)

* fix: removed backticks in inline code blocks

* added better error handling while cancelling uploads

* fix: inline code blocks, code blocks and links have saner behaviour

- Inline code blocks are now exitable, don't have backticks, have better padding vertically and better regex matching
- Code blocks on the top and bottom of the document are now exitable via Up and Down Arrow keys
- Links are now exitable while being autolinkable via a custom re-write of the tiptap-link-extension

* fix: more robust link checking
@Palanikannan1437 Palanikannan1437 mentioned this pull request Jan 23, 2024
Merged
@Palanikannan1437 Palanikannan1437 added this to the v0.15-dev milestone Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

Assignees

@Palanikannan1437 Palanikannan1437

Labels
🐛bug Something isn't working ✍️editor
Projects
None yet
Milestone
v0.15-dev
Development

Successfully merging this pull request may close these issues.
2 participants
@Palanikannan1437 @sriramveeraghanta