fix: Pages mutation on component mount #3230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lsPage component - Set the `revalidate` option to `false` in the `commonSwrOptions` object. - Add an `useEffect` hook that calls the `mutatePageDetails` function with specific options. - Inside the `useEffect` hook, set `revalidate` to `true`, `populateCache` to `true`, and define a rollback function for error handling. - If an error occurs during the rollback, display an error alert message using the `actionCompleteAlert` function. - In the `updatePage` function, ensure that `workspaceSlug`, `projectId`, and `pageId` are all defined before proceeding.
Palanikannan1437
changed the title
In the `packages/editor/core/src/ui/extensions/index.tsx` file, the code for inline code styling in the CoreEditorExtensions component has been updated. Previously, it was set to `false`, but now it is defined as an object with specific HTML attributes. The code styling includes a rounded-md background, custom primary color, margin, padding, font styling, and disabling spellcheck. This change improves the visual appearance and readability of inline code elements in the editor.
sriramveeraghanta
approved these changes
Dec 26, 2023
This was referenced Dec 30, 2023
Palanikannan1437
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
revalidateoption tofalsein thecommonSwrOptionsobject to fix issues with Locking, Archiving, etc.useEffecthook that calls themutatePageDetailsfunction with specific options as temporary fix to update cache.useEffecthook, setrevalidatetotrue,populateCachetotrueto update cache on component mount and define a rollback function for error handling.