Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feats: Add localization #2321

Closed
wants to merge 22 commits into from

Conversation

thomasync
Copy link
Contributor

@thomasync thomasync commented Sep 29, 2023

Add a global translation for Plane

  • A script to help find all the texts to be translated
  • A script to reload locales in Plane, so you don't have to run start.sh every time
  • Global function to import in every file (I chose to put the function in useMobxStore, as it was already imported in many files
  • Add FR Locale
  • Resolve the errors that occur when I touch files in web/layouts/*.
  • Review each file
  • Translate web files
  • Translate space files (not yet planned)

Technical specifications:

The majority of commits are simply the replacement of strings by localized(string), hence the large number of modified files.

Files added with business logic are only :

  • web/components/core/localization/*
  • web/helpers/localization.helper.ts
  • web/store/locale.ts

There are also optional, but very useful, scripts for working on localization:

  • scripts/localization.js: Find all untranslated strings in en_US.json and add them. But also add it to all other translations with a null to be edited.
  • scripts/reload-locales.sh: Returns modified translations directly, without having to run start.sh again.

@vercel
Copy link

vercel bot commented Sep 29, 2023

@thomasync is attempting to deploy a commit to the Plane Team on Vercel.

A member of the Team first needs to authorize it.

@thomasync thomasync marked this pull request as ready for review October 3, 2023 22:31
Copy link
Contributor Author

@thomasync thomasync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reported without bugs or problems.

@Kritikkkaaa
Copy link
Contributor

Hey @thomasync
We have this in our pipeline and will be pushed in one of our upcoming releases.

@thomasync thomasync force-pushed the feats-localization branch 2 times, most recently from 565dbce to 07d9272 Compare October 4, 2023 14:17
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@thomasync thomasync closed this Feb 11, 2024
@thomasync thomasync deleted the feats-localization branch February 11, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants