Skip to content

Commit

Permalink
address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
rahulramesha committed Sep 24, 2024
1 parent 5a16b2e commit f220592
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { MutableRefObject } from "react";
import clone from "lodash/clone";
import { observer } from "mobx-react";
import {
GroupByColumnTypes,
Expand Down
2 changes: 1 addition & 1 deletion web/core/store/issue/cycle/filter.store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ export class CycleIssuesFilter extends IssueFilterHelperStore implements ICycleI
});

if (this.getShouldClearIssues(updatedDisplayFilters)) {
this.rootIssueStore.cycleIssues.clear(true, true); // clear issues for local db when some filters like layout changes
this.rootIssueStore.cycleIssues.clear(true, true); // clear issues for local store when some filters like layout changes
}

if (this.getShouldReFetchIssues(updatedDisplayFilters)) {
Expand Down
2 changes: 1 addition & 1 deletion web/core/store/issue/module/filter.store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ export class ModuleIssuesFilter extends IssueFilterHelperStore implements IModul
});

if (this.getShouldClearIssues(updatedDisplayFilters)) {
this.rootIssueStore.moduleIssues.clear(true, true); // clear issues for local db when some filters like layout changes
this.rootIssueStore.moduleIssues.clear(true, true); // clear issues for local store when some filters like layout changes
}

if (this.getShouldReFetchIssues(updatedDisplayFilters)) {
Expand Down
2 changes: 1 addition & 1 deletion web/core/store/issue/project-views/filter.store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ export class ProjectViewIssuesFilter extends IssueFilterHelperStore implements I
});

if (this.getShouldClearIssues(updatedDisplayFilters)) {
this.rootIssueStore.projectIssues.clear(true, true); // clear issues for local db when some filters like layout changes
this.rootIssueStore.projectIssues.clear(true, true); // clear issues for local store when some filters like layout changes
}

if (this.getShouldReFetchIssues(updatedDisplayFilters)) {
Expand Down
2 changes: 1 addition & 1 deletion web/core/store/issue/project/filter.store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ export class ProjectIssuesFilter extends IssueFilterHelperStore implements IProj
});

if (this.getShouldClearIssues(updatedDisplayFilters)) {
this.rootIssueStore.projectIssues.clear(true, true); // clear issues for local db when some filters like layout changes
this.rootIssueStore.projectIssues.clear(true, true); // clear issues for local store when some filters like layout changes
}

if (this.getShouldReFetchIssues(updatedDisplayFilters)) {
Expand Down

0 comments on commit f220592

Please sign in to comment.