chore: issue relation hard delete

makeplane · Sep 20, 2024 · dcf6da6 · dcf6da6
1 parent 66cfc73
commit dcf6da6
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 7 deletions.
diff --git a/apiserver/plane/api/views/project.py b/apiserver/plane/api/views/project.py
@@ -301,11 +301,16 @@ def patch(self, request, slug, pk):
             if serializer.is_valid():
                 serializer.save()
                 if serializer.data["inbox_view"]:
-                    Inbox.objects.get_or_create(
-                        defaults={"name": f"{project.name} Inbox"},
+                    inbox = Inbox.objects.filter(
                         project=project,
                         is_default=True,
-                    )
+                    ).first()
+                    if not inbox:
+                        Inbox.objects.create(
+                            name=f"{project.name} Inbox",
+                            project=project,
+                            is_default=True,
+                        )
 
                     # Create the triage state in Backlog group
                     State.objects.get_or_create(

diff --git a/apiserver/plane/app/views/issue/relation.py b/apiserver/plane/app/views/issue/relation.py
@@ -267,7 +267,7 @@ def remove_relation(self, request, slug, project_id, issue_id):
             IssueRelationSerializer(issue_relation).data,
             cls=DjangoJSONEncoder,
         )
-        issue_relation.delete()
+        issue_relation.delete(soft=False)
         issue_activity.delay(
             type="issue_relation.activity.deleted",
             requested_data=json.dumps(request.data, cls=DjangoJSONEncoder),

diff --git a/apiserver/plane/app/views/project/base.py b/apiserver/plane/app/views/project/base.py
@@ -438,11 +438,16 @@ def partial_update(self, request, slug, pk=None):
             if serializer.is_valid():
                 serializer.save()
                 if serializer.data["inbox_view"]:
-                    Inbox.objects.get_or_create(
-                        defaults={"name": f"{project.name} Inbox"},
+                    inbox = Inbox.objects.filter(
                         project=project,
                         is_default=True,
-                    )
+                    ).first()
+                    if not inbox:
+                        Inbox.objects.create(
+                            name=f"{project.name} Inbox",
+                            project=project,
+                            is_default=True,
+                        )
 
                     # Create the triage state in Backlog group
                     State.objects.get_or_create(