improved variable names

makeplane · Sep 9, 2024 · d1621d9 · d1621d9
1 parent 0ad9429
commit d1621d9
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/web/core/components/modules/module-card-item.tsx b/web/core/components/modules/module-card-item.tsx
@@ -12,8 +12,8 @@ import { Card, FavoriteStar, LayersIcon, LinearProgressIndicator, TOAST_TYPE, To
 import { DateRangeDropdown } from "@/components/dropdowns";
 import { ButtonAvatars } from "@/components/dropdowns/member/avatar";
 import { ModuleQuickActions } from "@/components/modules";
+import { ModuleStatusDropdown } from  "@/components/modules/module-status-dropdown";
 // constants
-import { ModuleStatusSelection } from  "@/components/modules/module-status-dropdown";
 import { PROGRESS_STATE_GROUPS_DETAILS } from "@/constants/common";
 import { MODULE_FAVORITED, MODULE_UNFAVORITED } from "@/constants/event-tracker";
 import { MODULE_STATUS } from "@/constants/module";
@@ -45,8 +45,7 @@ export const ModuleCardItem: React.FC<Props> = observer((props) => {
   const {
     membership: { currentProjectRole },
   } = useUser();
-  const { updateModuleDetails } = useModule();
-  const { getModuleById, addModuleToFavorites, removeModuleFromFavorites } = useModule();
+  const { getModuleById, addModuleToFavorites, removeModuleFromFavorites, updateModuleDetails } = useModule();
   const { getUserDetails } = useMember();
   const { captureEvent } = useEventTracker();
   const { currentActiveEstimateId, areEstimateEnabledByProjectId, estimateById } = useProjectEstimates();
@@ -212,7 +211,7 @@ export const ModuleCardItem: React.FC<Props> = observer((props) => {
               </Tooltip>
               <div className="flex items-center gap-2" onClick={handleEventPropagation}>
                 {moduleStatus && (
-                  <ModuleStatusSelection
+                  <ModuleStatusDropdown
                   isDisabled={isDisabled}
                   moduleDetails={moduleDetails}
                   handleModuleDetailsChange={handleModuleDetailsChange}

diff --git a/web/core/components/modules/module-list-item-action.tsx b/web/core/components/modules/module-list-item-action.tsx
@@ -12,8 +12,8 @@ import { FavoriteStar, TOAST_TYPE, Tooltip, setPromiseToast, setToast } from "@p
 // components
 import { DateRangeDropdown } from "@/components/dropdowns";
 import { ModuleQuickActions } from "@/components/modules";
+import { ModuleStatusDropdown } from  "@/components/modules/module-status-dropdown";
 // constants
-import { ModuleStatusSelection } from  "@/components/modules/module-status-dropdown";
 import { MODULE_FAVORITED, MODULE_UNFAVORITED } from "@/constants/event-tracker";
 import { MODULE_STATUS } from "@/constants/module";
 import { EUserProjectRoles } from "@/constants/project";
@@ -33,11 +33,10 @@ export const ModuleListItemAction: FC<Props> = observer((props) => {
   // router
   const { workspaceSlug, projectId } = useParams();
   //   store hooks
-  const { updateModuleDetails } = useModule();
   const {
     membership: { currentProjectRole },
   } = useUser();
-  const { addModuleToFavorites, removeModuleFromFavorites } = useModule();
+  const { addModuleToFavorites, removeModuleFromFavorites, updateModuleDetails } = useModule();
   const { getUserDetails } = useMember();
   const { captureEvent } = useEventTracker();
 
@@ -131,7 +130,6 @@ export const ModuleListItemAction: FC<Props> = observer((props) => {
 
   return (
     <>
-
       <DateRangeDropdown
         buttonContainerClassName={`h-6 w-full flex ${isDisabled ? "cursor-not-allowed" : "cursor-pointer"} items-center gap-1.5 text-custom-text-300 border-[0.5px] border-custom-border-300 rounded text-xs`}
         buttonVariant="transparent-with-text"
@@ -155,7 +153,7 @@ export const ModuleListItemAction: FC<Props> = observer((props) => {
       />
 
       {moduleStatus && (
-        <ModuleStatusSelection
+        <ModuleStatusDropdown
         isDisabled={isDisabled}
         moduleDetails={moduleDetails}
         handleModuleDetailsChange={handleModuleDetailsChange}

diff --git a/web/core/components/modules/module-status-dropdown.tsx b/web/core/components/modules/module-status-dropdown.tsx
@@ -1,16 +1,16 @@
-import { MODULE_STATUS } from '@/constants/module'
+import React, { FC } from 'react'
+import { observer } from 'mobx-react';
 import { IModule } from '@plane/types';
 import { CustomSelect, TModuleStatus, ModuleStatusIcon } from '@plane/ui'
-import { observer } from 'mobx-react';
-import React, { FC } from 'react'
+import { MODULE_STATUS } from '@/constants/module'
 
 type Props = {
     isDisabled: boolean;
     moduleDetails: IModule;
     handleModuleDetailsChange: (payload: Partial<IModule>) => Promise<void>;
 };
 
-export const ModuleStatusSelection : FC<Props> = observer((props : Props) => {
+export const ModuleStatusDropdown : FC<Props> = observer((props : Props) => {
     const {isDisabled, moduleDetails, handleModuleDetailsChange} = props;
     const moduleStatus = MODULE_STATUS.find((status) => status.value === moduleDetails.status);