chore: allow guests/ viewers to comment. (#3515)

makeplane · Jan 30, 2024 · c9d2ea3 · c9d2ea3
1 parent f0836ce
commit c9d2ea3
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 25 deletions.
diff --git a/web/components/issues/issue-detail/inbox/main-content.tsx b/web/components/issues/issue-detail/inbox/main-content.tsx
@@ -79,7 +79,7 @@ export const InboxIssueMainContent: React.FC<Props> = observer((props) => {
       </div>
 
       <div className="pb-12">
-        <IssueActivity workspaceSlug={workspaceSlug} projectId={projectId} issueId={issueId} disabled={!is_editable} />
+        <IssueActivity workspaceSlug={workspaceSlug} projectId={projectId} issueId={issueId} />
       </div>
     </>
   );

diff --git a/web/components/issues/issue-detail/issue-activity/comments/comment-create.tsx b/web/components/issues/issue-detail/issue-activity/comments/comment-create.tsx
@@ -17,7 +17,6 @@ const fileService = new FileService();
 type TIssueCommentCreate = {
   workspaceSlug: string;
   activityOperations: TActivityOperations;
-  disabled: boolean;
   showAccessSpecifier?: boolean;
 };
 
@@ -40,7 +39,7 @@ const commentAccess: commentAccessType[] = [
 ];
 
 export const IssueCommentCreate: FC<TIssueCommentCreate> = (props) => {
-  const { workspaceSlug, activityOperations, disabled, showAccessSpecifier = false } = props;
+  const { workspaceSlug, activityOperations, showAccessSpecifier = false } = props;
   const workspaceStore = useWorkspace();
   const workspaceId = workspaceStore.getWorkspaceBySlug(workspaceSlug as string)?.id as string;
 
@@ -94,7 +93,7 @@ export const IssueCommentCreate: FC<TIssueCommentCreate> = (props) => {
                 }
                 submitButton={
                   <Button
-                    disabled={isSubmitting || disabled}
+                    disabled={isSubmitting}
                     variant="primary"
                     type="submit"
                     className="!px-2.5 !py-1.5 !text-xs"

diff --git a/web/components/issues/issue-detail/issue-activity/root.tsx b/web/components/issues/issue-detail/issue-activity/root.tsx
@@ -13,7 +13,6 @@ type TIssueActivity = {
   workspaceSlug: string;
   projectId: string;
   issueId: string;
-  disabled: boolean;
 };
 
 type TActivityTabs = "all" | "activity" | "comments";
@@ -43,7 +42,7 @@ export type TActivityOperations = {
 };
 
 export const IssueActivity: FC<TIssueActivity> = observer((props) => {
-  const { workspaceSlug, projectId, issueId, disabled } = props;
+  const { workspaceSlug, projectId, issueId } = props;
   // hooks
   const { createComment, updateComment, removeComment } = useIssueDetail();
   const { setToastAlert } = useToast();
@@ -147,14 +146,11 @@ export const IssueActivity: FC<TIssueActivity> = observer((props) => {
                 activityOperations={activityOperations}
                 showAccessSpecifier={project.is_deployed}
               />
-              {!disabled && (
-                <IssueCommentCreate
-                  workspaceSlug={workspaceSlug}
-                  activityOperations={activityOperations}
-                  disabled={disabled}
-                  showAccessSpecifier={project.is_deployed}
-                />
-              )}
+              <IssueCommentCreate
+                workspaceSlug={workspaceSlug}
+                activityOperations={activityOperations}
+                showAccessSpecifier={project.is_deployed}
+              />
             </div>
           ) : activityTab === "activity" ? (
             <IssueActivityRoot issueId={issueId} />
@@ -166,14 +162,11 @@ export const IssueActivity: FC<TIssueActivity> = observer((props) => {
                 activityOperations={activityOperations}
                 showAccessSpecifier={project.is_deployed}
               />
-              {!disabled && (
-                <IssueCommentCreate
-                  workspaceSlug={workspaceSlug}
-                  activityOperations={activityOperations}
-                  disabled={disabled}
-                  showAccessSpecifier={project.is_deployed}
-                />
-              )}
+              <IssueCommentCreate
+                workspaceSlug={workspaceSlug}
+                activityOperations={activityOperations}
+                showAccessSpecifier={project.is_deployed}
+              />
             </div>
           )}
         </div>

diff --git a/web/components/issues/issue-detail/main-content.tsx b/web/components/issues/issue-detail/main-content.tsx
@@ -99,7 +99,7 @@ export const IssueMainContent: React.FC<Props> = observer((props) => {
         disabled={!is_editable}
       />
 
-      <IssueActivity workspaceSlug={workspaceSlug} projectId={projectId} issueId={issueId} disabled={!is_editable} />
+      <IssueActivity workspaceSlug={workspaceSlug} projectId={projectId} issueId={issueId} />
     </>
   );
 });
diff --git a/web/components/issues/peek-overview/view.tsx b/web/components/issues/peek-overview/view.tsx
@@ -234,7 +234,6 @@ export const IssueView: FC<IIssueView> = observer((props) => {
                           workspaceSlug={workspaceSlug}
                           projectId={projectId}
                           issueId={issueId}
-                          disabled={disabled}
                         />
                       </div>
                     ) : (
@@ -255,7 +254,6 @@ export const IssueView: FC<IIssueView> = observer((props) => {
                               workspaceSlug={workspaceSlug}
                               projectId={projectId}
                               issueId={issueId}
-                              disabled={disabled}
                             />
                           </div>
                         </div>