Skip to content

Commit

Permalink
[WEB-1380] chore: fix sidebar expanding issue on sign out. (#4557)
Browse files Browse the repository at this point in the history
* [WEB-1380] chore: fix sidebar expanding issue on sign out.

* chore: update sign-out redirect url.

* dev: update signout view and fix the entrypoint on docker-compose-local

* chore: remove localStorage reset logic for `app_sidebar_collapsed` on sign-out.

---------

Co-authored-by: pablohashescobar <nikhilschacko@gmail.com>
  • Loading branch information
prateekshourya29 and pablohashescobar authored May 22, 2024
1 parent 577996b commit 2b27f39
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 8 deletions.
10 changes: 4 additions & 6 deletions apiserver/plane/authentication/views/app/signout.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
# Python imports
from urllib.parse import urljoin

# Django imports
from django.views import View
from django.contrib.auth import logout
Expand All @@ -23,9 +20,10 @@ def post(self, request):
user.save()
# Log the user out
logout(request)
url = urljoin(base_host(request=request, is_app=True), "sign-in")
return HttpResponseRedirect(url)
return HttpResponseRedirect(
base_host(request=request, is_app=True)
)
except Exception:
return HttpResponseRedirect(
base_host(request=request, is_app=True), "sign-in"
base_host(request=request, is_app=True)
)
2 changes: 1 addition & 1 deletion docker-compose-local.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ services:
- dev_env
volumes:
- ./apiserver:/code
command: ./bin/docker-entrypoint-api.sh
command: ./bin/docker-entrypoint-api-local.sh
env_file:
- ./apiserver/.env
depends_on:
Expand Down
1 change: 0 additions & 1 deletion web/store/root.store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ export class RootStore {
this.dashboard = new DashboardStore(this);
this.router = new RouterStore();
this.commandPalette = new CommandPaletteStore();
this.theme = new ThemeStore(this);
this.eventTracker = new EventTrackerStore(this);
this.instance = new InstanceStore();
this.user = new UserStore(this);
Expand Down

0 comments on commit 2b27f39

Please sign in to comment.