Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgres version update and minio client image add in values file #45

Closed
wants to merge 1 commit into from
Closed

Postgres version update and minio client image add in values file #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/plane-ce/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: Meet Plane. An open-source software development tool to manage issu

type: application

version: 1.0.24
version: 1.0.25
appVersion: "0.22.0"

home: https://plane.so
Expand Down
5 changes: 5 additions & 0 deletions charts/plane-ce/questions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,11 @@ questions:
type: string
default: "minio/minio:latest"
show_if: "minio.local_setup=true"
- variable: minio.image_mc
label: "MinIO Client Docker Image"
type: string
default: "minio/mc:latest"
show_if: "minio.local_setup=true"
- variable: minio.root_user
label: "Root User"
type: string
Expand Down
2 changes: 1 addition & 1 deletion charts/plane-ce/templates/workloads/minio.stateful.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ spec:
- secretRef:
name: {{ .Release.Name }}-doc-store-secrets
optional: false
image: minio/mc
image: {{ .Values.minio.image_mc }}
imagePullPolicy: {{ .Values.minio.pullPolicy }}
name: {{ .Release.Name }}-minio-bucket
serviceAccount: {{ .Release.Name }}-srv-account
Expand Down
3 changes: 2 additions & 1 deletion charts/plane-ce/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ redis:

postgres:
local_setup: true
image: postgres:15.5-alpine
image: postgres:15.7-alpine
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Hardcoded PostgreSQL 15.5 references found in multiple files.

The shell script identified several hardcoded references to postgres:15.5-alpine in the following files:

  • charts/plane-enterprise/questions.yml
  • charts/plane-enterprise/README.md
  • charts/plane-ce/questions.yml
  • charts/plane-ce/README.md

These references should be updated to postgres:15.7-alpine to maintain consistency and ensure that all components use the updated PostgreSQL version.

🔗 Analysis chain

Approve PostgreSQL version update with verification recommendation.

The update of the PostgreSQL image from version 15.5-alpine to 15.7-alpine is a good practice for maintaining security and stability. However, it's important to ensure compatibility with the rest of the system.

Please verify the following:

  1. Check the PostgreSQL 15.7 release notes for any breaking changes or deprecations.
  2. Test the application thoroughly with this new PostgreSQL version in a staging environment before deploying to production.
  3. Update any documentation or deployment guides that reference the PostgreSQL version.

To help with verification, you can run the following script to check for any hardcoded references to the old PostgreSQL version:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any hardcoded references to PostgreSQL 15.5
rg --type yaml --type markdown "postgres.*15\.5" .

Length of output: 726

servicePort: 5432
cliConnectPort: ""
storageClass: longhorn
Expand All @@ -59,6 +59,7 @@ rabbitmq:

minio:
image: minio/minio:latest
image_mc: minio/mc:latest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

🛠️ Refactor suggestion

Use a specific version tag for the MinIO Client image instead of latest.

The image_mc is currently set to minio/mc:latest, which can lead to unpredictable behavior in production environments. To ensure consistency and reproducibility across deployments, it's recommended to use a specific version tag.

Recommended Change:

image_mc: minio/mc:RELEASE.2023-05-04T18-10-16Z

You can find the latest stable version on the MinIO Client Docker Hub page.

🔗 Analysis chain

Consider using a specific version tag for the MinIO Client image.

While adding the MinIO Client image is beneficial for managing MinIO deployments, using the latest tag can lead to unpredictable behavior in production environments. It's recommended to use a specific version tag to ensure consistency across deployments.

Consider replacing the latest tag with a specific version. For example:

image_mc: minio/mc:RELEASE.2023-05-04T18-10-16Z

You can find the latest stable version on the MinIO Client Docker Hub page.

Additionally, to ensure the MinIO Client is properly configured, you may want to add the following verification step:

This will output the MinIO Client pod configuration from the rendered template, allowing you to verify that the image and any associated settings are correct.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify MinIO Client configuration
helm template . | grep -A 5 "name: minio-client"

Length of output: 122

Script:

#!/bin/bash
# Check the image_mc value in charts/plane-ce/values.yaml
grep 'image_mc:' charts/plane-ce/values.yaml

Length of output: 72

local_setup: true
pullPolicy: IfNotPresent
root_password: password
Expand Down
2 changes: 1 addition & 1 deletion charts/plane-enterprise/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: Meet Plane. An Enterprise software development tool to manage issue

type: application

version: 1.0.12
version: 1.0.13
appVersion: "1.3.0"

home: https://plane.so/
Expand Down
5 changes: 5 additions & 0 deletions charts/plane-enterprise/questions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,11 @@ questions:
type: string
default: "registry.plane.tools/plane/minio:latest"
show_if: "services.minio.local_setup=true"
- variable: services.minio.image_mc
label: "MinIO Client Docker Image"
type: string
default: "minio/mc:latest"
show_if: "services.minio.local_setup=true"
- variable: services.minio.root_user
label: "Root User"
type: string
Expand Down
2 changes: 1 addition & 1 deletion charts/plane-enterprise/templates/workloads/minio.stateful.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ spec:
- secretRef:
name: {{ .Release.Name }}-doc-store-secrets
optional: false
image: minio/mc
image: {{ .Values.services.minio.image_mc }}
imagePullPolicy: Always
name: {{ .Release.Name }}-minio-bucket
serviceAccount: {{ .Release.Name }}-srv-account
Expand Down
3 changes: 2 additions & 1 deletion charts/plane-enterprise/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ services:

postgres:
local_setup: true
image: registry.plane.tools/plane/postgres:15.5-alpine
image: registry.plane.tools/plane/postgres:15.7-alpine
servicePort: 5432
cliConnectPort: ''
volumeSize: 2Gi
Expand All @@ -57,6 +57,7 @@ services:
minio:
local_setup: true
image: registry.plane.tools/plane/minio:latest
image_mc: minio/mc:latest
volumeSize: 3Gi
root_user: admin
root_password: password
Expand Down