Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed ClusterIP and Imagepullpolicy #37

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

akshat5302
Copy link
Collaborator

@akshat5302 akshat5302 commented Sep 16, 2024

Changed ClusterIP for services and Imagepullpolicy of rabbitmq

Summary by CodeRabbit

  • New Features

    • Introduced a new configuration option for RabbitMQ deployment allowing users to specify the image pull policy with options: "Always," "IfNotPresent," and "Never."
  • Improvements

    • Updated RabbitMQ container configuration to use a dynamic image pull policy based on user-defined settings.
  • Configuration Changes

    • Modified image pull policies for multiple components to ensure the latest images are utilized.
    • Adjusted service exposure settings for several components to enhance networking within the Kubernetes cluster.

Copy link

coderabbitai bot commented Sep 16, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce a new configuration option for RabbitMQ in the Helm chart, allowing users to specify an Image Pull Policy with three options: "Always," "IfNotPresent," and "Never." This option is conditionally visible based on the rabbitmq.local_setup variable. Additionally, the imagePullPolicy in the RabbitMQ StatefulSet is modified to use this new configuration dynamically. Several components' pullPolicy settings are changed from IfNotPresent to Always, and assign_cluster_ip settings are adjusted from true to false for multiple components in the values file.

Changes

File Change Summary
charts/plane-ce/questions.yml Added rabbitmq.pullPolicy of type enum with options ["Always", "IfNotPresent", "Never"].
charts/plane-ce/templates/...yaml Modified imagePullPolicy in RabbitMQ StatefulSet from hardcoded "Always" to dynamic value from Helm values.
charts/plane-ce/values.yaml Modified pullPolicy for multiple components from IfNotPresent to Always; changed assign_cluster_ip from true to false.

Possibly related PRs

🐰 In the garden, I hop with glee,
New pull policies set me free!
"Always" or "IfNotPresent," my choice to make,
With each image pull, a new path I take.
Configured with care, my services thrive,
In this Kubernetes world, we’re so alive! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mguptahub mguptahub merged commit 6d023f0 into develop Sep 16, 2024
1 check was pending
@mguptahub mguptahub deleted the fix-ce-clusterip branch September 16, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants