FastBoot dependency whitelisting #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this won't work because of ember-fastboot/ember-cli-fastboot#188 |
|
You're right. I've changed the PR to simply update the README to notify of the need to add |
willviles
changed the title
marcoow
reviewed
Mar 1, 2017
README.md
Outdated
| @@ -605,6 +605,16 @@ import CookieStore from 'ember-simple-auth/session-stores/cookie'; | |||
| export default CookieStore.extend(); | |||
| ``` | |||
|
|
|||
| If you are using the [`OAuth2PasswordGrantAuthenticator`](http://ember-simple-auth.com/api/classes/OAuth2PasswordGrantAuthenticator.html), you must add `node-fetch` to your list of FastBoot whitelisted dependencies in `package.json`: | |||
There was a problem hiding this comment.
This actually applies to the Devise authenticator as well.
There was a problem hiding this comment.
Can you format the text so that it adheres to the 80 chars line limit for consistency with the rest of the README?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds node-fetch to fastbootDependencies
This PR fixes Ember Simple Auth from breaking in Fastboot when using the OAuth2PasswordGrant authenticator, as referenced in #1138. The fix is to simply add node-fetch to the addon's whitelistedfastbootDependencies.See below for updated PR info.