Use PathEscape instead of QueryEscape in httpGetter #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrawn01
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Thank you for the PR! This is indeed an issue! Ideally the key should never have been in the URL path as some routers do not path escape in the correct order and can therefore cause upstream routers to incorrectly route the URL. It should have been a query parameter instead. This fix solves the problem for us just fine. thank you again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a couple of small fixes to http.go:
PathEscapeinstead ofQueryEscapefor building request URLs. The HTTP handler usesPathUnescapeso this roundtrips keys containing space characters correctly.[]bytetostring.