feat: do not count context cancelation as peer error #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the incoming internal groupcache request gets canceled, it should not count as a peer error.
With the current code, it's impossible to separate context cancelations (which might be outside the control of the service running groupcache) from "real" peer errors.
Also, with this PR, in case the internal request times-out (via
context
), the requesting peer can still do its own error accounting.WDYT?