Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumping sharp version to 0.28.3 to support arm64 on macOS #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benjibee
Copy link

@benjibee benjibee commented Jul 8, 2021

Fixes #150 by upgrading sharp to a version that support arm64 on macOS

@wszydlak
Copy link

wszydlak commented Jul 8, 2021

This also fixes #149

Copy link

@wszydlak wszydlak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm - it will potencially fix #149, but needs more changes to be compatible with sharp api.

Copy link

@wszydlak wszydlak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks that sharp api changed a lot, this PR needs more changes. It would be cool to write more tests to be sure gulp-responsive is compatible with sharp api. There needs to be done more changes.

@benjibee
Copy link
Author

benjibee commented Jul 8, 2021

That makes sense but I'm not enough into this project at the moment to write those tests.

I'm currently using it to create webp, png, and jpeg images in various sizes with renaming, etc. and it's so far without any errors though I understand that's not the same as test coverage ;)

@dutscher
Copy link

dutscher commented Aug 2, 2021

i have problems with node14. can we please push forward the upgrade to 0.28.3?

cheers

@ingomc
Copy link

ingomc commented Aug 3, 2021

i also want it to use with node >= 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Needs update to sharp 0.28.3 to support arm64 (M1) architecture
4 participants