Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@react-native-community/async-storage => @react-native-async-storage/async-storage in RN Bare Package #479

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

Ariflo
Copy link
Contributor

@Ariflo Ariflo commented Mar 23, 2023

πŸ“¦ Pull Request

@react-native-community/async-storage has been deprecated and replaced by @react-native-async-storage/async-storage. This updates our dependencies to match the update.

βœ… Fixed Issues

n/a

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@Ariflo Ariflo added the patch Increment the patch version when merged label Mar 23, 2023
@Ariflo Ariflo requested review from Ethella and ayv8er March 23, 2023 00:54
@Ariflo Ariflo self-assigned this Mar 23, 2023
@shortcut-integration
Copy link

@Ariflo Ariflo changed the title @react-native-community/async-storage => @react-native-async-storage/async-storage @react-native-community/async-storage => @react-native-async-storage/async-storage in RN Bare Package Mar 23, 2023
@Ethella
Copy link
Member

Ethella commented Mar 23, 2023

Is it tested?

@Ariflo
Copy link
Contributor Author

Ariflo commented Mar 23, 2023

Is it tested?

yes with magiclabs/react-native-demo#43

@Ariflo Ariflo force-pushed the ariflo-sc-72161-update-peer-and-dev-dependencies branch from 19c99bc to 1ac8e19 Compare March 24, 2023 19:47
@Ariflo Ariflo merged commit b563ad5 into master Mar 24, 2023
@Ariflo Ariflo deleted the ariflo-sc-72161-update-peer-and-dev-dependencies branch March 24, 2023 19:59
@magiclabsFE
Copy link

πŸš€ PR was released in @magic-ext/react-native-bare-oauth@9.0.1, @magic-sdk/react-native-bare@15.0.1 πŸš€

@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Mar 24, 2023
@madelinecameron
Copy link

madelinecameron commented Mar 25, 2023

Hi,

It looks like the submitter's local test didn't work and the requester acknowledged that the app wasn't running magiclabs/react-native-demo#43 (comment). I don't know if that entirely necessitates a revert but might be worth it to keep main potentially healthy*

Even before this, there is something odd going on with the async storage where it crashes apps in production but not when running off an expo server

Error: [@RNC/AsyncStorage]: NativeModule: AsyncStorage is null.

This is happening on an Android emulator Pixel_5_API_31 but my FlightTest iOS app on 16.0.3 also crashes with a memory exception at 0x0 w/o anymore of a useful error but doesn't when I remove the Magic-SDK entirely so it seems to indicate something is wrong with the package.

That's all to say, maybe this will fix this issue, maybe not but something weird with asyncstorage is definitely already happening.

@Ariflo
Copy link
Contributor Author

Ariflo commented Mar 27, 2023

Hi @madelinecameron, thanks for reaching out; it turns out that the issue I mentioned on magiclabs/react-native-demo#43 (comment) wasn't related to this update away from @react-native-community/async-storage.

That said, we're working to resolve the issue asap and in the meantime have unpublished the new version of the sdks. For now, please point you expo based application to @magic-sdk/react-native-expo v14.6.2 and your bare RN applications to the same version for @magic-sdk/react-native-bare.

Please do continue to let us know if you still run into issues. Fwiw, the Error: [@RNC/AsyncStorage]: NativeModule: AsyncStorage is null. error usually crops up in bare packages that haven't updated their pods via cd iOS && pod install. Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants