Sc 68969 immutable stark error

[mattupham]

📦 Why? (Required)

Immutable tested this line of code with 3 providers

• magic provider
• alchemy provider
• json rpc provider
  await contract.connect(PROVIDER).isRegistered(userPublicStarkKey);

The error from Ethers using the Magic Provider was different than the Alchemy / JSON RPC Providers
This fix makes the error from the Magic Provider consistent with the other providers

Ethers expects a data key to be present in the RPC error - if data is present from bubbled up error, we now map this in the MagicRPCError - see here https://www.jsonrpc.org/specification#response_object

How was it tested? (Required)

How did you test/validate correctness of changes?

1. Recreate the error in a 3rd party app (example)
2. Set breakpoints in the ethers library to figure out where the error was called, and what data was missing
3. Modified phantom locally to map the missing data
4. Modified magic-sdk locally, linked changes to the 3rd party app using the magic-sdk
5. Verified that the error from the Magic Provider is consistent now with the other providers
6. Create the canary version of magic-sdk, push to npm, test the canary version in a 3rd party app

Screenshots (Optional)

Previous issue - inconsistent errors from Magic (top) and JSON RPC Provider / Alchemy provider (expected - middle, bottom)

success.magic.sdk.mov

3 consistent errors (after fixes) - Magic, JSON RPC, and Alchemy

Reviewer Notes (Optional)

For this to pass, the magic-sdk PR should be merged in first (type from magic-sdk now expects the data key)

PR Description Guide

⚠️ Don't forget to add a semver label!

Please only add one label:

• patch: Bug Fix?
• minor: New Feature?
• major: Breaking Change?
• skip-release: It's unnecessary to publish this change.

[shortcut-integration]

This pull request has been linked to Shortcut Story #68969: Immutable - Magic rpcProvider interaction bug when calling Stark contract methods.

[Ariflo]

LGTM

[magiclabsFE]

🚀 PR was released in @magic-ext/algorand@8.6.1, @magic-ext/avalanche@8.6.1, @magic-ext/bitcoin@8.6.1, @magic-ext/conflux@6.6.1, @magic-ext/connect@6.7.1, @magic-ext/cosmos@8.6.1, @magic-ext/ed25519@4.6.1, @magic-ext/flow@8.7.1, @magic-ext/harmony@8.6.1, @magic-ext/icon@8.6.1, @magic-ext/near@8.6.1, @magic-ext/oauth@7.6.1, @magic-ext/polkadot@8.6.1, @magic-ext/react-native-bare-oauth@8.6.1, @magic-ext/react-native-expo-oauth@8.7.1, @magic-ext/solana@9.6.1, @magic-ext/taquito@5.6.1, @magic-ext/terra@5.6.1, @magic-ext/tezos@8.6.1, @magic-ext/webauthn@7.6.1, @magic-ext/zilliqa@8.6.1, @magic-sdk/commons@9.6.1, @magic-sdk/pnp@7.6.1, @magic-sdk/provider@13.6.1, @magic-sdk/react-native-bare@14.6.1, @magic-sdk/react-native-expo@14.6.1, @magic-sdk/types@11.6.1, magic-sdk@13.6.1 🚀