Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents Relayer from Overriding Status Bar Color #436

Merged
merged 3 commits into from
Jan 24, 2023

Conversation

Ariflo
Copy link
Contributor

@Ariflo Ariflo commented Jan 21, 2023

πŸ“¦ Pull Request

Upgrades our React Native package offerings react-native-webview to the latest and utilizes autoManageStatusBarEnabled attribute in Webview to prevent style bug.

βœ… Fixed Issues

🚨 Test instructions

Utilize expo demo app and yarn add @magic-sdk/react-native-expo@14.0.1-903c2bf-2 canary version. Check issue ☝️ for reproduction steps.

⚠️ Don't forget to add a semver label!

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@Ariflo Ariflo added the patch Increment the patch version when merged label Jan 21, 2023
@Ariflo Ariflo requested a review from Ethella January 21, 2023 01:11
@Ariflo Ariflo self-assigned this Jan 21, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #69015: [CS Ticket Template].

@Ariflo Ariflo changed the title Ariflo sc 69015 fix status bar color error Upgrades react-native-webview to latest and Sets autoManageStatusBarEnabled to false Jan 21, 2023
@Ariflo Ariflo changed the title Upgrades react-native-webview to latest and Sets autoManageStatusBarEnabled to false Upgrades react-native-webview to latest and Sets autoManageStatusBarEnabled to false Jan 21, 2023
@Ariflo Ariflo changed the title Upgrades react-native-webview to latest and Sets autoManageStatusBarEnabled to false Prevents Relayer from Overriding Status Bar Color Jan 21, 2023
@Ariflo Ariflo force-pushed the ariflo-sc-69015-fix-status-bar-color-error branch from 903c2bf to d65602e Compare January 24, 2023 20:31
@Ariflo Ariflo merged commit e279e6b into master Jan 24, 2023
@Ariflo Ariflo deleted the ariflo-sc-69015-fix-status-bar-color-error branch January 24, 2023 21:48
@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webview in relayer overrides status bar color
4 participants