Replaces WebView View wrapper with SafeAreaView #431
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π¦ Pull Request
Replaces the View wrapping the RN SDK package
WebView
with a SafeAreaView to prevent UI overlap with device hardware.β Fixed Issues
π¨ Test instructions
Using either the bare or expo sample apps, install either
@magic-sdk/react-native-bare@13.1.1-9591571-2
or@magic-sdk/react-native-expo@13.1.1-9591571
canary versions. Update the login method to utilize Magic's SMS login feature.Screenshots
Before
After
patch
: Bug Fix?minor
: New Feature?major
: Breaking Change?skip-release
: It's unnecessary to publish this change.