Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE ]add install step in publish stage. #425

Merged
merged 1 commit into from
Jan 5, 2023
Merged

[CHORE ]add install step in publish stage. #425

merged 1 commit into from
Jan 5, 2023

Conversation

kgrubb
Copy link
Contributor

@kgrubb kgrubb commented Jan 5, 2023

📦 Pull Request

Follow up to fix the last failing action. This adds the install step to the publish job, since it is needed before the shipit command can complete.

@kgrubb kgrubb added the skip-release Preserve the current version when merged label Jan 5, 2023
@kgrubb kgrubb requested review from Ariflo and Ethella January 5, 2023 19:33
@kgrubb kgrubb self-assigned this Jan 5, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #68022: Fix github action publishing process in magic-js.

Ariflo
Ariflo approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@Ariflo Ariflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ariflo Ariflo removed the skip-release Preserve the current version when merged label Jan 5, 2023
@kgrubb kgrubb added the patch Increment the patch version when merged label Jan 5, 2023
@kgrubb kgrubb merged commit ce881e0 into master Jan 5, 2023
@kgrubb kgrubb deleted the madisongrubb-sc-68022-include-install-during-publish branch January 5, 2023 19:53
@magiclabsFE
Copy link

🚀 PR was released in @magic-ext/algorand@7.0.0, @magic-ext/avalanche@7.0.0, @magic-ext/bitcoin@7.0.0, @magic-ext/conflux@5.0.0, @magic-ext/connect@5.0.0, @magic-ext/cosmos@7.0.0, @magic-ext/ed25519@3.0.0, @magic-ext/flow@7.0.0, @magic-ext/harmony@7.0.0, @magic-ext/icon@7.0.0, @magic-ext/near@7.0.0, @magic-ext/oauth@6.0.0, @magic-ext/polkadot@7.0.0, @magic-ext/react-native-oauth@6.0.0, @magic-ext/solana@8.0.0, @magic-ext/taquito@4.0.0, @magic-ext/terra@4.0.0, @magic-ext/tezos@7.0.0, @magic-ext/webauthn@6.0.0, @magic-ext/zilliqa@7.0.0, @magic-sdk/commons@8.0.0, @magic-sdk/pnp@6.0.0, @magic-sdk/provider@12.0.0, @magic-sdk/react-native@13.0.0, magic-sdk@12.0.0 🚀

@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ariflo Ariflo Ariflo approved these changes

@Ethella Ethella Awaiting requested review from Ethella

Assignees

@kgrubb kgrubb

Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgrubb @magiclabsFE @Ariflo