Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Resolve shipit release issue #424

Merged
merged 4 commits into from
Jan 5, 2023
Merged

[CHORE] Resolve shipit release issue #424

merged 4 commits into from
Jan 5, 2023

Conversation

kgrubb
Copy link
Contributor

@kgrubb kgrubb commented Jan 5, 2023 •
edited
Loading

📦 Pull Request

This is another shot at getting the shipit command to pass cleanly. This utilizes --immutable to ensure the lockfile isn't changed.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #68022: Fix github action publishing process in magic-js.

@kgrubb kgrubb changed the title Yarn install with --frozen-lockfile to prevent dirty directory [CHORE] Resolve shipit release issue Jan 5, 2023
@kgrubb kgrubb added the skip-release Preserve the current version when merged label Jan 5, 2023
@kgrubb kgrubb self-assigned this Jan 5, 2023
@kgrubb kgrubb requested review from Ethella and Ariflo January 5, 2023 17:47
Ariflo
Ariflo previously approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@Ariflo Ariflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgrubb kgrubb marked this pull request as ready for review January 5, 2023 18:06
Ariflo
Ariflo approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@Ariflo Ariflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgrubb kgrubb merged commit b0863df into master Jan 5, 2023
@kgrubb kgrubb deleted the madisongrubb-sc-68022-fix-github-action-publishing branch January 5, 2023 19:07
@magiclabsFE
Copy link

🚀 PR was released in @magic-ext/algorand@7.0.0, @magic-ext/avalanche@7.0.0, @magic-ext/bitcoin@7.0.0, @magic-ext/conflux@5.0.0, @magic-ext/connect@5.0.0, @magic-ext/cosmos@7.0.0, @magic-ext/ed25519@3.0.0, @magic-ext/flow@7.0.0, @magic-ext/harmony@7.0.0, @magic-ext/icon@7.0.0, @magic-ext/near@7.0.0, @magic-ext/oauth@6.0.0, @magic-ext/polkadot@7.0.0, @magic-ext/react-native-oauth@6.0.0, @magic-ext/solana@8.0.0, @magic-ext/taquito@4.0.0, @magic-ext/terra@4.0.0, @magic-ext/tezos@7.0.0, @magic-ext/webauthn@6.0.0, @magic-ext/zilliqa@7.0.0, @magic-sdk/commons@8.0.0, @magic-sdk/pnp@6.0.0, @magic-sdk/provider@12.0.0, @magic-sdk/react-native@13.0.0, magic-sdk@12.0.0 🚀

@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ariflo Ariflo Ariflo approved these changes

@Ethella Ethella Awaiting requested review from Ethella

Assignees

@kgrubb kgrubb

Labels
released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgrubb @magiclabsFE @Ariflo