Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [sc-68022] Fix github action publishing process in magic-js #420

Conversation

Ethella
Copy link
Member

@Ethella Ethella commented Jan 5, 2023

Story details: https://app.shortcut.com/magic-labs/story/68022

  • remove yarn command in Create Release phase, as it would fail due to a discrepancy in the yarn.lock file after bumping local versions

failed build
https://github.com/magiclabs/magic-js/actions/runs/3842939483/jobs/6544740907

Originally in CircleCI, the command sequence are

yarn auto version
yarn lerna version
yarn run build
yarn auto shipit

https://app.circleci.com/pipelines/github/magiclabs/magic-js/1242/workflows/bb743c78-9ec1-4acf-9fd6-0cacdfd9c027/jobs/3602

…o a discrepancy in the yarn.lock file after bumping local versions
@Ethella Ethella requested a review from kgrubb January 5, 2023 01:36
@Ethella Ethella self-assigned this Jan 5, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #68022: Fix github action publishing process in magic-js.

@Ethella Ethella requested a review from Ariflo January 5, 2023 01:43
@Ethella Ethella merged commit 6e6fea9 into master Jan 5, 2023
@Ethella Ethella deleted the jerryliu-sc-68022-fix-github-action-publishing-process-in-magic branch January 5, 2023 01:48
@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants