Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoginWithEmailOtp Whitelabeling #414

Merged
merged 9 commits into from
Feb 28, 2023
Merged

LoginWithEmailOtp Whitelabeling #414

merged 9 commits into from
Feb 28, 2023

Conversation

mushfichowdhury-magic
Copy link
Contributor

@mushfichowdhury-magic mushfichowdhury-magic commented Jan 4, 2023 •
edited
Loading

📦 Pull Request

For the Email OTP White Labeling project, SDK needed updates to support the showUI? param and also introduce new typing for events.

✅ Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

@mushfichowdhury-magic mushfichowdhury-magic added the minor Increment the minor version when merged label Jan 4, 2023
@mushfichowdhury-magic mushfichowdhury-magic self-assigned this Jan 4, 2023
@mushfichowdhury-magic mushfichowdhury-magic mentioned this pull request Jan 4, 2023
Closed
Ethella
Ethella previously approved these changes Feb 28, 2023
View reviewed changes
Ethella
Ethella reviewed Feb 28, 2023
View reviewed changes
packages/@magic-sdk/provider/src/modules/auth.ts
);
if (!showUI) {
const handle = this.request<string | null, LoginWithEmailOTPEvents>(requestPayload);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the chance 'handle' is undefined in this case?

Copy link
Contributor Author

@mushfichowdhury-magic mushfichowdhury-magic Feb 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's a slim chance, previous implementation always had it assumed as defined.

@mushfichowdhury-magic mushfichowdhury-magic merged commit fea9d43 into master Feb 28, 2023
@mushfichowdhury-magic mushfichowdhury-magic deleted the mushfichowdhury-login-with-email-otp-whitelabel branch February 28, 2023 17:11
@magiclabsFE
Copy link

🚀 PR was released in @magic-ext/algorand@8.5.0, @magic-ext/avalanche@8.5.0, @magic-ext/bitcoin@8.5.0, @magic-ext/conflux@6.5.0, @magic-ext/connect@6.6.0, @magic-ext/cosmos@8.5.0, @magic-ext/ed25519@4.5.0, @magic-ext/flow@8.5.0, @magic-ext/harmony@8.5.0, @magic-ext/icon@8.5.0, @magic-ext/near@8.5.0, @magic-ext/oauth@7.5.0, @magic-ext/polkadot@8.5.0, @magic-ext/react-native-bare-oauth@8.5.0, @magic-ext/react-native-expo-oauth@8.6.0, @magic-ext/solana@9.5.0, @magic-ext/taquito@5.5.0, @magic-ext/terra@5.5.0, @magic-ext/tezos@8.5.0, @magic-ext/webauthn@7.5.0, @magic-ext/zilliqa@8.5.0, @magic-sdk/commons@9.5.0, @magic-sdk/pnp@7.5.0, @magic-sdk/provider@13.5.0, @magic-sdk/react-native-bare@14.5.0, @magic-sdk/react-native-expo@14.5.0, @magic-sdk/types@11.5.0, magic-sdk@13.5.0 🚀

@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethella Ethella Ethella left review comments

@dgerrellsMagic dgerrellsMagic dgerrellsMagic approved these changes

Assignees

@mushfichowdhury-magic mushfichowdhury-magic

Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mushfichowdhury-magic @magiclabsFE @Ethella @dgerrellsMagic