Mushfichowdhury sc 61149 implement event emitting in magic sdk #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #61149: Implement event emitting in Magic SDK based on new RPC route. |
mushfichowdhury-magic
requested review from
bcleary06,
dgerrellsMagic and
Ethella
|
@dgerrellsMagic added unit test for no args, 1 args, 2 args, and null arg |
packages/@magic-sdk/provider/test/spec/modules/base-module/request.spec.ts
Outdated
Show resolved
Hide resolved
dgerrellsMagic
previously approved these changes
Nov 17, 2022
Ethella
reviewed
Nov 17, 2022
packages/@magic-sdk/provider/test/spec/modules/base-module/request.spec.ts
Show resolved
Hide resolved
Ethella
reviewed
Nov 17, 2022
|
Thx for answering. LGTM |
Ethella
approved these changes
Nov 17, 2022
mushfichowdhury-magic
deleted the
mushfichowdhury-sc-61149-implement-event-emitting-in-magic-sdk-based
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
Bidirectional RPC Event Support