Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds more Context about Expo dependency in @magic-ext/react-native-oauth to README #386

Merged
merged 4 commits into from
Nov 10, 2022

Conversation

Ariflo
Copy link
Contributor

@Ariflo Ariflo commented Nov 10, 2022

πŸ“¦ Pull Request

Adds more context about the use of expo-web-browser dependency in @magic-ext/react-native-oauth.

βœ… Fixed Issues

n/a

🚨 Test instructions

n/a

⚠️ Don't forget to add a semver label!

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@Ariflo Ariflo requested a review from Ethella November 10, 2022 20:51
@Ariflo Ariflo self-assigned this Nov 10, 2022
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #65206: Resolve error trying to implement OAuth in RN.

Ethella
Ethella previously approved these changes Nov 10, 2022
Copy link
Member

@Ethella Ethella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ariflo Ariflo merged commit ce33398 into master Nov 10, 2022
@Ariflo Ariflo deleted the ariflo-sc-65206-update-read-me-oauth-rn branch November 10, 2022 23:20
@sagarjeu
Copy link

sagarjeu commented Dec 2, 2022

[Error: Magic Extension Error (oauth): [The method or property WebBrowser.openBrowserAsync is not available on android, are you sure you've linked all the native dependencies properly?] An error has occurred]

Raact native cil error

@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants