Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add getWalletInfo method #352

Merged
merged 8 commits into from
Nov 1, 2022
Merged

add getWalletInfo method #352

merged 8 commits into from
Nov 1, 2022

Conversation

hcote
Copy link
Contributor

@hcote hcote commented Aug 24, 2022 •
edited
Loading

📦 Pull Request

[Provide a general summary of the pull request here.]

Adds new method getWalletInfo() which returns an object with the wallet type that the user is logged in with (magic, metamask, wallet_connect or coinbase_wallet)

✅ Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@hcote hcote added the patch Increment the patch version when merged label Aug 24, 2022
@hcote hcote closed this Aug 24, 2022
@hcote hcote reopened this Oct 30, 2022
@hcote hcote changed the title add getWalletType method add getWalletInfo method Oct 31, 2022
@hcote
Copy link
Contributor Author

hcote commented Oct 31, 2022

https://app.shortcut.com/magic-labs/story/58953/add-getwalletinfo-to-connect-sdk

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #58953: Add getWalletInfo to connect sdk.

@hcote hcote requested a review from harryEth October 31, 2022 18:08
bcleary06
bcleary06 previously approved these changes Oct 31, 2022
View reviewed changes
@hcote hcote added minor Increment the minor version when merged and removed patch Increment the patch version when merged labels Oct 31, 2022
harryEth
harryEth previously approved these changes Nov 1, 2022
View reviewed changes
@hcote hcote merged commit 301205d into master Nov 1, 2022
@hcote hcote deleted the hcote-add-get-wallet-type-method branch November 1, 2022 18:20
@magiclabsFE
Copy link

🚀 PR was released in @magic-ext/algorand@6.0.0, @magic-ext/avalanche@6.0.0, @magic-ext/bitcoin@6.0.0, @magic-ext/conflux@4.0.0, @magic-ext/connect@4.0.0, @magic-ext/cosmos@6.0.0, @magic-ext/ed25519@2.0.0, @magic-ext/flow@6.0.0, @magic-ext/harmony@6.0.0, @magic-ext/icon@6.0.0, @magic-ext/near@6.0.0, @magic-ext/oauth@5.0.0, @magic-ext/polkadot@6.0.0, @magic-ext/react-native-oauth@5.0.0, @magic-ext/solana@7.0.0, @magic-ext/taquito@3.0.0, @magic-ext/terra@3.0.0, @magic-ext/tezos@6.0.0, @magic-ext/webauthn@5.0.0, @magic-ext/zilliqa@6.0.0, @magic-sdk/commons@7.0.0, @magic-sdk/pnp@5.0.0, @magic-sdk/provider@11.0.0, @magic-sdk/react-native@12.0.0, @magic-sdk/types@10.0.0, magic-sdk@11.0.0 🚀

@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcleary06 bcleary06 bcleary06 approved these changes

@harryEth harryEth harryEth left review comments

@dgerrellsMagic dgerrellsMagic Awaiting requested review from dgerrellsMagic

Assignees
No one assigned
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hcote @magiclabsFE @bcleary06 @harryEth