Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magic-conflux extension #263

Merged
merged 1 commit into from
Jan 11, 2022
Merged

magic-conflux extension #263

merged 1 commit into from
Jan 11, 2022

Conversation

hcote
Copy link
Contributor

@hcote hcote commented Jan 10, 2022 •
edited by smithki
Loading

📦 Pull Request

Adds @magic-ext/conflux extension.

@hcote hcote self-assigned this Jan 10, 2022
@hcote hcote added patch Increment the patch version when merged skip-release Preserve the current version when merged labels Jan 10, 2022
smithki
smithki approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@smithki smithki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for @harryEth to review as well. LGTM from a code-quality and cleanliness PoV!

@smithki smithki merged commit e8c0647 into master Jan 11, 2022
@smithki smithki deleted the hcote-conflux-extension branch January 11, 2022 15:57
@smithki
Copy link
Contributor

smithki commented Jan 24, 2022

🚀 PR was released in @magic-ext/conflux@0.1.1, @magic-ext/solana@3.0.1 🚀

@smithki smithki added the released This issue/pull request has been released. label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smithki smithki smithki approved these changes

@harryEth harryEth harryEth approved these changes

Assignees

@hcote hcote

Labels
patch Increment the patch version when merged released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hcote @smithki @harryEth