Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jerryliu sc 44386 migrate web3 related magic ext repos to magic (PART 1) #248

Conversation

Ethella
Copy link
Member

@Ethella Ethella commented Dec 6, 2021

πŸ“¦ Pull Request

  • Local tested with RN env
  • All extension packages will have major version bumps.

βœ… Fixed Issues

https://app.shortcut.com/magic-labs/story/44386/migrate-web3-related-magic-ext-repos-to-magic-js-sdk-monorepo

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@Ethella Ethella added the skip-release Preserve the current version when merged label Dec 6, 2021
@Ethella Ethella requested a review from harryEth December 6, 2021 10:50
@shortcut-integration
Copy link

smithki
smithki previously approved these changes Dec 6, 2021
@smithki
Copy link
Contributor

smithki commented Dec 6, 2021

Please add a major semver label, when you get a chance!

@Ethella Ethella added major Increment the major version when merged and removed skip-release Preserve the current version when merged labels Dec 7, 2021
harryEth
harryEth previously approved these changes Dec 7, 2021
@Ethella Ethella dismissed stale reviews from harryEth and smithki via 82263ac December 8, 2021 08:27
@Ethella Ethella merged commit 2b7f124 into master Dec 8, 2021
@Ethella Ethella deleted the jerryliu-sc-44386-migrate-web3-related-magic-ext-repos-to-magic branch December 8, 2021 13:44
@smithki
Copy link
Contributor

smithki commented Dec 9, 2021

@smithki smithki added the released This issue/pull request has been released. label Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Increment the major version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants