Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with d.generateKey is undefined build bug #228

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

dgerrellsMagic
Copy link
Contributor

@dgerrellsMagic dgerrellsMagic commented Oct 19, 2021

📦 Pull Request

CDN bundles were affected by a mysterious d.generateKey is undefined bug. This would not break the user experience, but did prevent our session persistence mechanism from working correctly. Turns out the issue is related to a Babel plugin hoisting bug related to async/await.

⚠️ Don't forget to add a semver label!

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@dgerrellsMagic dgerrellsMagic added the patch Increment the patch version when merged label Oct 19, 2021
Copy link
Contributor

@smithki smithki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once tests pass! 👍

@smithki smithki changed the title fix bug with gen key undefiend and build bug Fix bug with d.generateKey is undefined build bug Oct 19, 2021
@smithki smithki merged commit 7536b01 into master Oct 19, 2021
@smithki smithki deleted the dgerrells-fix-webcrypto-bundle-issue branch October 19, 2021 21:42
@smithki smithki added the released This issue/pull request has been released. label Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants