Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from microbundle to esbuild #220

Merged
merged 20 commits into from
Jan 25, 2022
Merged

Switch from microbundle to esbuild #220

merged 20 commits into from
Jan 25, 2022

Conversation

smithki
Copy link
Contributor

@smithki smithki commented Sep 23, 2021

To speed up our development processes and improve the dependability of our CI/CD, this PR introduces esbuild to the Magic SDK build system, which has shown to drastically reduce build times. This change is considered breaking because Magic JS SDK packages no longer ship ES5-compatible code. This means that developers who require ES5 compatibility will need to lower the syntax/polyfill manually.

This change is on-hold pending new SDK features like SMS login & MFA compatibility.

@smithki smithki added the major Increment the major version when merged label Sep 23, 2021
@smithki smithki self-assigned this Sep 23, 2021
@smithki smithki changed the title Switch from microbundle to esbuild [HOLD MERGE] Switch from microbundle to esbuild Sep 23, 2021
@smithki
Copy link
Contributor Author

smithki commented Oct 20, 2021

Holy moly we need this...

Screen Shot 2021-10-20 at 11 29 31 AM

@smithki smithki changed the title [HOLD MERGE] Switch from microbundle to esbuild Switch from microbundle to esbuild Jan 25, 2022
@smithki smithki marked this pull request as ready for review January 25, 2022 18:03
@smithki smithki merged commit 69b4cd3 into master Jan 25, 2022
@smithki smithki deleted the feat/faster-builds branch January 25, 2022 18:23
@smithki smithki added the released This issue/pull request has been released. label Jan 25, 2022
@smithki smithki mentioned this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Increment the major version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant