Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register access control rpc error code #193

Merged
merged 2 commits into from
Aug 9, 2021

Conversation

Dizigen
Copy link
Contributor

@Dizigen Dizigen commented Aug 9, 2021

📦 Pull Request

With allowlist blocklist we are now supporting a new sdk errors that should be caught by the developer, will be thrown when:

  • when an app is private to an email OR
  • when the user is explicitly blocked

✅ Fixed Issues

https://app.clubhouse.io/magic-labs/story/41269/fe-throw-proper-error-when-allow-list-block-list-rules-violated

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@Dizigen Dizigen requested a review from smithki August 9, 2021 21:24
@Dizigen Dizigen self-assigned this Aug 9, 2021
@Dizigen Dizigen added the patch Increment the patch version when merged label Aug 9, 2021
smithki
smithki previously approved these changes Aug 9, 2021
@smithki smithki merged commit d1efd36 into master Aug 9, 2021
@smithki smithki deleted the add-access-control-rpc-error-code branch August 9, 2021 22:03
@smithki
Copy link
Contributor

smithki commented Aug 9, 2021

@smithki smithki added the released This issue/pull request has been released. label Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants