Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit JSDelivr entry-point for magic-sdk #191

Merged
merged 2 commits into from
Jul 28, 2021
Merged

Add explicit JSDelivr entry-point for magic-sdk #191

merged 2 commits into from
Jul 28, 2021

Conversation

smithki
Copy link
Contributor

@smithki smithki commented Jul 28, 2021 •
edited
Loading

📦 Pull Request

Adds an explicit JSDeliver entry-point resolution to the package.json file in the web project (magic-sdk).

Other notable changes include:

  • Update build system to prioritize ES modules
  • Prevent TypeScript build caches from being published to NPM

@smithki smithki added the minor Increment the minor version when merged label Jul 28, 2021
@smithki smithki self-assigned this Jul 28, 2021
dgerrellsMagic
dgerrellsMagic approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@dgerrellsMagic dgerrellsMagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is the js delivr stuff huh? Nice! LGTM

@smithki
Copy link
Contributor Author

smithki commented Jul 28, 2021

So this is the js delivr stuff huh? Nice! LGTM

It's a start

@smithki smithki merged commit 6e692df into master Jul 28, 2021
@smithki smithki deleted the smithki-add-jsdelivr-entrypoint branch July 28, 2021 19:16
@smithki
Copy link
Contributor Author

smithki commented Jul 28, 2021

🚀 PR was released in @magic-sdk/commons@1.2.0, @magic-sdk/provider@4.4.0, @magic-sdk/react-native@4.4.0, @magic-sdk/types@3.2.0, magic-sdk@4.4.0 🚀

@smithki smithki added the released This issue/pull request has been released. label Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgerrellsMagic dgerrellsMagic dgerrellsMagic approved these changes

Assignees

@smithki smithki

Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smithki @dgerrellsMagic