Skip to content

Commit

Permalink
Bold monorepo + link to rn readme in root
Browse files Browse the repository at this point in the history
  • Loading branch information
Ariflo committed Nov 23, 2022
1 parent e548971 commit 58e5013
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@

## 📖 Documentation

See the [developer documentation](https://docs.magic.link) to learn how you can master the Magic SDK in a matter of minutes.
- See the [developer documentation](https://docs.magic.link) to learn how you can master the Magic SDK in a matter of minutes.
- See the `@magic-sdk/react-native` [README](https://github.com/magiclabs/magic-js/tree/master/packages/%40magic-sdk/react-native#readme) for package specific information.

## ⚡️ Quick Start

Expand Down Expand Up @@ -94,6 +95,7 @@ Test specific files
```bash
yarn test /test/**/constructor.spec.ts
```
<<<<<<< Updated upstream

## 🙌🏾 Troubleshooting

Expand All @@ -106,3 +108,5 @@ For React Native projects living within a monorepo that run into the following `
When attempting to import `Magic`, take note that the React Native metro bundler doesn’t work well with symlinks, which tend to be utilized by most package managers.

For this issue consider using Microsoft's [rnx-kit](https://microsoft.github.io/rnx-kit/docs/guides/bundling) suite of tools that include a plugin for metro that fixes this symlink related error.
=======
>>>>>>> Stashed changes
2 changes: 1 addition & 1 deletion packages/@magic-sdk/react-native/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ await magic.auth.loginWithMagicLink({ email: 'your.email@example.com' });

### Symlinking in Monorepo w/ Metro (Expo Only)

For React Native projects living within a monorepo that run into the following `TypeError: Undefined is not an object` error:
For React Native projects living within a **monorepo** that run into the following `TypeError: Undefined is not an object` error:

<img width="299" alt="Screenshot 2022-11-23 at 12 19 19 PM" src="https://user-images.githubusercontent.com/13407884/203641477-ec2e472e-86dc-4a22-b54a-eb694001617e.png">

Expand Down

0 comments on commit 58e5013

Please sign in to comment.