PWA-2655 :Update magento-compatibility.js to indicate all dependencie… #4300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and just not magento
|
glo42707
requested changes
Jul 22, 2024
There was a problem hiding this comment.
please udpate below accordingly
var magentoVersion = '2.4.7-p1';
backend dependencies should aligned to only PWA core backed metapackages
"magento/module-upward-connector": "^2.0.4",
"magento/venia-sample-data": "^0.0.5",
"magento/venia-sample-data-ee": "^0.0.4",
"magento/pwa": "^0.7.2",
"magento/pwa-commerce": "^0.0.4"
m2-community-project
bot
moved this from Ready for Review
to Changes Requested
in Pull Request Progress
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: ready for review
labels
m2-community-project
bot
moved this from Changes Requested
to Reviewer Approved
in Pull Request Progress
m2-community-project
bot
added
Progress: approved
and removed
Progress: changes requested
labels
glo82145
approved these changes
Jul 25, 2024
m2-community-project
bot
moved this from Reviewer Approved
to Done
in Pull Request Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s and just not magento
Description
Update magento-compatibility.js to indicate all dependencies and just not magento
Related Issue
Closes: https://jira.corp.adobe.com/browse/PWA-2655
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist