Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA/dev user should not required to input html suffix in front end for… #4290

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

glo11372
Copy link
Collaborator

@glo11372 glo11372 commented Jul 5, 2024

… loading page

Description

1.Open venia and click any category then go to PDP page, it will open .html in URL

Related Issue

Closes #https://jira.corp.adobe.com/browse/PWA-3291

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@glo11372 glo11372 added version: Patch This changeset includes backwards compatible bug fixes. pkg:venia-ui labels Jul 5, 2024
@glo11372 glo11372 requested a review from glo82145 July 5, 2024 08:36
@glo11372 glo11372 self-assigned this Jul 5, 2024
@m2-community-project m2-community-project bot added this to Review in Progress in Pull Request Progress Jul 5, 2024
@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫

Unit tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • packages/peregrine/lib/talons/Gallery/__tests__/useGallery.spec.js
Messages
📖

Associated JIRA tickets: PWA-3291.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: unitTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 13c20cf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: review version: Patch This changeset includes backwards compatible bug fixes.
Projects
Pull Request Progress
Review in Progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants